Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop puppetca_split_configs parameter #605

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jul 1, 2020

Since module version 13 this module is Foreman 2.0+ which means we must always use split configs. That makes this parameter redundant.

Since module version 13 this module is Foreman 2.0+ which means we must
always use split configs. That makes this parameter redundant.
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The Travis failures seem unrelated, but it'd be cool to have it green before merging I guess :)

@ekohl
Copy link
Member Author

ekohl commented Jul 1, 2020

Some builds stalled for 10m in Travis. Going to guess that's some CI issue and I restarted those builds.

@ekohl
Copy link
Member Author

ekohl commented Jul 1, 2020

💚 now

@ehelms ehelms merged commit 476dfbe into theforeman:master Jul 1, 2020
@ekohl ekohl deleted the drop-puppetca-split-configs branch July 1, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants